Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-next] snappy: fix build on x86_64-darwin #144941

Merged
merged 1 commit into from
Nov 7, 2021
Merged

[staging-next] snappy: fix build on x86_64-darwin #144941

merged 1 commit into from
Nov 7, 2021

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Nov 6, 2021 •
edited
Loading

Needs patch for compatibility with clang 7

Motivation for this change

Fixup #143058
For #144730

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-burns
snappy: fix build on x86_64-darwin
f3de649 
Needs patch for compatibility with clang 7
@r-burns
Copy link
Contributor Author

r-burns commented Nov 7, 2021 •
edited
Loading

Confirmed that this unblocks mariadb-server constituent on x86_64-darwin

@SuperSandro2000 SuperSandro2000 merged commit 84c1377 into NixOS:staging-next Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-burns @SuperSandro2000